[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

2019-08-27 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG39aa8954a484: Move EH spec mismatches under -fms-compatibility (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66770/new/ https://reviews.l

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

2019-08-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66770/new/ https://reviews.llvm.org/D66770 ___ cfe

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

2019-08-26 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. This will definitely help us clean up our code, since we run the MSVC STL test suite with `-fno-ms-compatibility -fno-delayed-template-parsing`. Other possible occurrences of ms-extensions that should be considered ms-compatibility: - ParseDeclCXX.cpp says "MSVC permi

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

2019-08-26 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added a reviewer: hans. Herald added a project: clang. -fms-extensions is intended to enable conforming language extensions and -fms-compatibility is intended to language rule relaxations, so a user could plausibly compile with -fno-ms-compatibility on Windows while