[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

This revision was automatically updated to reflect the committed changes. Closed by commit rG2535f04338c6: [clang] Ensure that comment classes are trivially destructible (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66722/ne

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

riccibruno updated this revision to Diff 217063. riccibruno added a comment. Also test that `DeclInfo` is trivially destructible. Thanks ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66722/new/ https://reviews.llvm.org/D66722 Files: clang/lib/AST/Comment.cp

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Regarding adding a test for `DeclInfo` -- SGTM as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66722/new/ https://reviews.llvm.org/D66722 _

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

Mordante added a reviewer: gribozavr. Mordante added a subscriber: gribozavr. Mordante added a comment. Please also add a test for the `DeclInfo` struct. It isn't a `CommentNode` but also allocated with the `BumpPtrAllocator`. I also like @gribozavr's input. Repository: rC Clang CHANGES SINC

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, Mordante. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. As in D66646 , these classes are also allocated with a `BumpPtrAllocator`, and therefore should be tri