[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:308 +//===--===// +// Unsinged analyzer options. +//===--

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

MaskRay added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:308 +//===--===// +// Unsinged analyzer options. +//===--

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

NoQ added a comment. Until we do enough debugging to understand the nature of these false positives, i recommend silencing the checker when it has false positives. Later we can improve the granularity of our checkers, so that to be able to disable smaller portions of them, or make constraint so

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

Szelethus added a comment. In D66721#1644514 , @NoQ wrote: > No-no, you're disabling the checkers here but you should be silencing them. > This will be crashing because modeling is disabled. > > I also recommend checker options, even if they apply to mult

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

Charusso added a comment. In D66721#1644531 , @NoQ wrote: > Now you're silencing the *whole* checker. This is equivalent to passing an > `-analyzer-silence-checker` flag. I am silencing the *whole* checker if and only if a bitwise operation or a shift

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

NoQ added a comment. Now you're silencing the *whole* checker. This is equivalent to passing an `-analyzer-silence-checker` flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66721/new/ https://reviews.llvm.org/D66721 ___ cfe-commits mail

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

Charusso updated this revision to Diff 217062. Charusso marked 4 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66721/new/ https://reviews.llvm.org/D66721 Files: clang/include/clang

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:305 +"Whether the bitwise (and shift) operations should be checked.", +false) + NoQ wrote: > We didn't do enough debugging to

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:305 +"Whether the bitwise (and shift) operations should be checked.", +false) + We didn't do enough debugging to demonstrate that t

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

NoQ added a comment. No-no, you're disabling the checkers here but you should be silencing them. This will be crashing because modeling is disabled. I also recommend checker options, even if they apply to multiple checkers (@Szelethus mentioned that package options are a thing, you might use th

[PATCH] D66721: [analyzer] Analysis: Prevent bitwise operation false positives

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This patch introduces a new `analyzer-config` configuration: `-