This revision was automatically updated to reflect the committed changes.
jsji marked an inline comment as done.
Closed by commit rL370902: [PowerPC][Altivec] Fix constant argument for vec_dss
(authored by jsji, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
jsji marked 2 inline comments as done.
jsji added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-error.c:78
+void testDSS(int index) {
+ vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must
be a constant integer}}
+
wuzish w
jsji updated this revision to Diff 218479.
jsji added a comment.
Add range check and test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66699/new/
https://reviews.llvm.org/D66699
Files:
clang/include/clang/Basic/BuiltinsPPC.def
clang/lib/Head
wuzish added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-error.c:78
+void testDSS(int index) {
+ vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must
be a constant integer}}
+
It would be better if add range constraint ch
jsji added a comment.
Ping..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66699/new/
https://reviews.llvm.org/D66699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
jsji created this revision.
jsji added reviewers: nemanjai, hfinkel.
Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton.
Herald added a project: clang.
jsji added a reviewer: PowerPC.
Herald added a subscriber: wuzish.
This is similar to vec_ct* in https://reviews.llvm.org/rL304205.
