This revision was automatically updated to reflect the committed changes.
Closed by commit rG528f5da6d862: Debug Info: Support for DW_AT_export_symbols
for anonymous structs (authored by shafik).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D7?vs=217457&i
shafik updated this revision to Diff 217457.
shafik marked an inline comment as done.
shafik added a comment.
Simplifying test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7/new/
https://reviews.llvm.org/D7
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-exp
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenCXX/debug-info-export_symbols.cpp:4
+// CHECK: [[SCOPE:![0-9]+]] = distinct !DICompositeType({{.*}}flags:
DIFlagTypePassByValue
+// CHECK: !DIC
shafik updated this revision to Diff 217271.
shafik marked an inline comment as done.
shafik added a comment.
Updating test to be more specific
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D7/new/
https://reviews.llvm.org/D7
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCX
aprantl added inline comments.
Comment at: test/CodeGenCXX/debug-info-export_symbols.cpp:3
+
+// CHECK-DAG: !DICompositeType({{.*}}flags: DIFlagExportSymbols |
DIFlagTypePassByValue
+struct A {
This should just be `CHECK:` if it stands by itself.
It would be be
shafik created this revision.
shafik added a reviewer: aprantl.
shafik added a project: debug-info.
shafik added a parent revision: D66605: Debug Info: Support for
DW_AT_export_symbols for anonymous structs.
This implements the DWARF 5 feature described in:
http://dwarfstd.org/ShowIssue.php?issu
