This revision was automatically updated to reflect the committed changes.
Closed by commit rL369884: [clangd] Send highlighting diff beyond the end of
the file. (authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
h
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:625
+ testing::UnorderedElementsAre(
+ testing::AllOf(LineNumber(3), EmptyHighlightings()),
+
jvikstrom accepted this revision.
jvikstrom added a comment.
This revision is now accepted and ready to land.
It feels a bit strange to be sending highlighting (even if they are empty)
beyond eof. But I guess the proposal does not specify this and it would make
life for the vscode extension (mu
hokein created this revision.
hokein added a reviewer: jvikstrom.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
This would make the client life (tracking the changes) easier.
Repository:
rG LLVM Github Monorepo
https://reviews.ll
