This revision was automatically updated to reflect the committed changes.
Closed by commit rL369993: [clang-scan-deps] Skip UTF-8 BOM in source minimizer
(authored by aganea, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
aganea marked an inline comment as done.
aganea added inline comments.
Comment at: lib/Lex/DependencyDirectivesSourceMinimizer.cpp:822
bool Minimizer::minimizeImpl(const char *First, const char *const End) {
+ skipUTF8ByteOrderMark(First, End);
while (First != End)
-
dexonsmith added inline comments.
Comment at: lib/Lex/DependencyDirectivesSourceMinimizer.cpp:822
bool Minimizer::minimizeImpl(const char *First, const char *const End) {
+ skipUTF8ByteOrderMark(First, End);
while (First != End)
Is skipping this the right th
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66511/new/
https://reviews.llvm.org/D66511
___
cfe-commit
aganea created this revision.
aganea added reviewers: arphaman, dexonsmith, Bigcheese.
aganea added a project: clang.
Herald added a subscriber: tschuett.
As per title.
Repository:
rC Clang
https://reviews.llvm.org/D66511
Files:
lib/Lex/DependencyDirectivesSourceMinimizer.cpp
test/Lexer/