[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-22 Thread Puyan Lotfi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369715: [clang][ifs] New interface stubs format (llvm triple based). (authored by zer0, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-22 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383 +auto VD = cast(E.first)->getType(); +OS << "Object, Size: " + << context.getTypeSizeInChars(VD).getQ

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-22 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a test case for read/write, otherwise LGTM. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383 +auto VD = cast(E.first)->getType

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-19 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 216004. plotfi added a comment. Adding ObjectFileFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66446/new/ https://reviews.llvm.org/D66446 Files: clang/include/clang/Frontend/FrontendActions.h clang/i

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-19 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 +

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

2019-08-19 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:363 + OS << "IfsVersion: 1.0\n"; + OS << "Triple: " << T.str() << "\n"; + OS << "Symbols:\n"; This is missing O