[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

This revision was automatically updated to reflect the committed changes. Closed by commit rL369214: [clang-format] Fix a bug that joins template closer and = (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6631 + verifyFormat("a = 1;", Style); + verifyFormat("a >>= 1;", Style); Quuxplusone wrote: > Actually, could you add a test case specif

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan added a comment. In D66384#1634405 , @Quuxplusone wrote: > although I would still question whether > `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. See here

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

Quuxplusone added a comment. LGTM too, although I would still question whether `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. Comment at: clang/unittests/Format/FormatTest.cpp:6631 + verifyFormat("a = 1;", Style); + verifyFormat("a >>= 1;", St

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

Quuxplusone added a comment. LGTM too, although I would still question whether `Style.SpaceBeforeAssignmentOperators` is providing anyone any benefit at all. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66384/new/ https://reviews.llvm.org/D66384

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66384/new/ https://reviews.llvm.org/D66384 __

[PATCH] D66384: [clang-format] Fix a bug that joins template closer and =

owenpan created this revision. owenpan added reviewers: Quuxplusone, MyDeveloperDay, sammccall, klimek, djasper. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also fixes the documentation for `SpaceBeforeAssignmentOperators`. See the discussion here