Re: [PATCH] D66361: Improve behavior in the case of stack exhaustion.

On Tue, 3 Sep 2019 at 17:59, Kamil Rytarowski via Phabricator via cfe-commits wrote: > krytarowski added a comment. > > In D66361#1656037 , @rsmith > wrote: > > > In D66361#1655903 , > @krytarowski wrote: > > > > >

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

krytarowski added a comment. In D66361#1656037 , @rsmith wrote: > In D66361#1655903 , @krytarowski > wrote: > > > This change broke on NetBSD. > > > > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22003/ste

Re: [PATCH] D66361: Improve behavior in the case of stack exhaustion.

On Tue, Sep 03, 2019 at 06:02:28PM +, Richard Smith - zygoloid via Phabricator via cfe-commits wrote: > rsmith added a comment. > > In D66361#1655903 , @krytarowski > wrote: > > > This change broke on NetBSD. > > > > http://lab.llvm.org:8011/builders

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith added a comment. In D66361#1655903 , @krytarowski wrote: > This change broke on NetBSD. > > http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22003/steps/run%20unit%20tests/logs/FAIL%3A%20Clang%3A%3Astack-exhaustion.cpp Test disabled for NetBS

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

krytarowski added a comment. This change broke on NetBSD. http://lab.llvm.org:8011/builders/netbsd-amd64/builds/22003/steps/run%20unit%20tests/logs/FAIL%3A%20Clang%3A%3Astack-exhaustion.cpp (view as text) TEST 'Clang :: SemaTemplate/stack-exhaustion.cpp' FAILED

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG26a92d5852b2: Improve behavior in the case of stack exhaustion. (authored by Richard Smith ). Changed prior to commit: https://reviews.llvm.org/D66361?vs=216520&id=217212#toc

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from an accidental newline change. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:15 let CategoryName = "Semantic Issue" in { - def note_pr

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 216520. rsmith marked 5 inline comments as done. rsmith added a comment. - Address review comments from Aaron. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/ https://reviews.llvm.org/D66361 Files: include/clang/Ba

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:14 let Component = "Sema" in { -let CategoryName = "Semantic Issue" in { +def warn_stack_exhausted : Warning< + "stack nearly exhausted; compilation time may suffer, and " aaro

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:14 let Component = "Sema" in { -let CategoryName = "Semantic Issue" in { +def warn_stack_exhausted : Warning< + "stack nearly exhausted; compilation time may suffer, and " --

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith added inline comments. Comment at: lib/Basic/Stack.cpp:53-54 + // If the stack pointer has a surprising value, we do not understand this + // stack usage scheme. (Perhaps the target allocates new stack regions on + // demand for us.) Don't try to guess what's going on.

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 215680. rsmith added a comment. - Disable stack exhaustion test if threads are disabled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/ https://reviews.llvm.org/D66361 Files: include/clang/Basic/DiagnosticSemaKind

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith updated this revision to Diff 215678. rsmith marked 2 inline comments as done. rsmith added a comment. - Review feedback: use _AddressOfReturnAddress with MSVC, and simplify Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66361/new/ https://reviews.llvm.org/

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rnk added inline comments. Comment at: include/clang/Basic/Stack.h:42 + llvm::function_ref Fn) { +if (LLVM_UNLIKELY(isStackNearlyExhausted())) { + runWithSufficientStackSpaceSlow(Diag, Fn); For LLVM_THREADS_DISABL

[PATCH] D66361: Improve behavior in the case of stack exhaustion.

rsmith created this revision. rsmith added reviewers: rnk, aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Clang performs various recursive operations (such as template instantiation), and may use non-trivial amounts of stack space in each recursive ste