This revision was automatically updated to reflect the committed changes.
Closed by commit rL369758: [Docs][OpenCL] Release 9.0 notes for OpenCL
(authored by stulova, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
hans accepted this revision.
hans added a comment.
lgtm, and many thanks for writing release notes!
Go ahead and commit to the branch directly with SVN or let me know if you'd
like me to do it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66294/new/
https://reviews.llvm.org/D66294
mantognini accepted this revision.
mantognini added a comment.
This revision is now accepted and ready to land.
Thanks for addressing my comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66294/new/
https://reviews.llvm.org/D66294
___
Anastasia updated this revision to Diff 215894.
Anastasia added a comment.
- Added empty line and ; as requested on the review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66294/new/
https://reviews.llvm.org/D66294
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
mantognini added inline comments.
Comment at: docs/ReleaseNotes.rst:209
+Implemented features are:
+- Address space behavior is improved in majority of C++ features:
+
I think Sphinx/RST wants an empty line here.
Nitpicking for consistency, could you have a `;`
Anastasia updated this revision to Diff 215598.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66294/new/
https://reviews.llvm.org/D66294
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.
Anastasia added inline comments.
Comment at: docs/ReleaseNotes.rst:173
+
+- Added initial support for implicitly including OpenCL BIFs using
+ efficient trie lookup generated by TableGen. A corresponding
svenvh wrote:
> mantognini wrote:
> > If the BIF acronym w
Anastasia updated this revision to Diff 215591.
Anastasia marked 5 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66294/new/
https://reviews.llvm.org/D66294
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
==
svenvh added inline comments.
Comment at: docs/ReleaseNotes.rst:173
+
+- Added initial support for implicitly including OpenCL BIFs using
+ efficient trie lookup generated by TableGen. A corresponding
mantognini wrote:
> If the BIF acronym wasn't introduced befo
mantognini requested changes to this revision.
mantognini added a comment.
This revision now requires changes to proceed.
The overall structure seems alright. I'll let people more familiar with the
code-base judge whether other important features should be added there as well.
Anastasia created this revision.
Anastasia added reviewers: svenvh, mantognini, hans.
Herald added subscribers: ebevhan, jfb, yaxunl.
https://reviews.llvm.org/D66294
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--
11 matches
Mail list logo