[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-09-04 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. r371010 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-14 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec added a comment. Didn't you forget to update test/CodeGenOpenCL/amdgpu-features.cl? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-14 Thread Stanislav Mekhanoshin via Phabricator via cfe-commits
rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commi

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-14 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. Looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-14 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 215168. arsenm added a comment. rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 Files: include/clang/Basic/BuiltinsAMDGPU.def lib/Basic/Targets/AMDGPU.cpp test/CodeGenOpenCL/builtins-amdgcn-ci.cl

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-14 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. Looks fine to me. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

2019-08-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. arsenm added a parent revision: D66197: AMDGPU: Add intrinsics for address space identification. https://reviews.llvm.org/D66198