[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

2019-08-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. The heuristics for properly rendering the comments are probably a good way to go. I'd say this change is still a step in the right direction - text blocks in formatted strings should be properly escaped to avoid being interpreted like markdown constructs. Any stru

[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

2019-08-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Added a bit of a braindump to https://github.com/clangd/clangd/issues/95 I think always forcing a break is maybe at least as bad as forcing no break, and we should aim to be cleverer. Some (relatively) simple punctuation/capitalization/line-length based heuristics may

[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

2019-08-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/95 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66087