[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-09-16 Thread Nicholas Allegra via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372058: Push lambda scope earlier when transforming lambda expression (authored by comex, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-26 Thread Nicholas Allegra via Phabricator via cfe-commits
comex added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics lebedev.ri wrote: > Mordante

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-26 Thread Nicholas Allegra via Phabricator via cfe-commits
comex updated this revision to Diff 217230. comex marked 2 inline comments as done. comex added a comment. Addressed review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66067/new/ https://reviews.llvm.org/D66067 Files: lib/Sema/TreeTransform.h tes

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-24 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a reviewer: aaron.ballman. lebedev.ri added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnost

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-24 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics comex wrote: > Mordante w

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-18 Thread Nicholas Allegra via Phabricator via cfe-commits
comex marked an inline comment as done. comex added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics -

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-17 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics Wouldn't it be better to

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-11 Thread Nicholas Allegra via Phabricator via cfe-commits
comex updated this revision to Diff 214572. comex added a comment. Oops, I forgot to re-run `git diff` after fixing the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66067/new/ https://reviews.llvm.org/D66067 Files: clang/lib/Sema/TreeTransform.h clang/test/SemaTemplate/defa

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

2019-08-11 Thread Nicholas Allegra via Phabricator via cfe-commits
comex created this revision. comex added reviewers: rsmith, faisalv, Mordante. Herald added a project: clang. Herald added a subscriber: cfe-commits. When first parsing a lambda expression, `BuildDeclRefExpr` is called on the parameter declarations with the lambda scope already pushed. But when