[PATCH] D66031: clangd: use -j for background index pool

hans added a comment. In D66031#1623935 , @sammccall wrote: > @hans If you don't mind merging this, it's a nice usability improvement. Sure! Merged in r368569. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ htt

[PATCH] D66031: clangd: use -j for background index pool

sammccall added a subscriber: hans. sammccall added a comment. @hans If you don't mind merging this, it's a nice usability improvement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031

[PATCH] D66031: clangd: use -j for background index pool

This revision was automatically updated to reflect the committed changes. Closed by commit rL368498: clangd: use -j for background index pool (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D66031: clangd: use -j for background index pool

puremourning added a comment. In D66031#1623855 , @sammccall wrote: > Thanks! Want me to land this for you? yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. Thanks! Want me to land this for you? Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: >

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214463. puremourning added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-t

[PATCH] D66031: clangd: use -j for background index pool

puremourning marked an inline comment as done. puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > puremourning wrote: >

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214460. puremourning marked an inline comment as not done. puremourning added a comment. Herald added subscribers: jfb, javed.absar. Always use physical cores rather than logical cores for best performance. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66031: clangd: use -j for background index pool

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: > sammccall wrote: > > can we use `std::max(Opts.AsyncThreadsCount, 1)

[PATCH] D66031: clangd: use -j for background index pool

puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > can we use `std::max(Opts.AsyncThreadsCount, 1)` instead? > > Havin

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214454. puremourning marked 3 inline comments as done. puremourning added a comment. When -sync -background-index supplied, use 1 thread for background index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, this is much better than only having `-background-index=no`. I think we should merge this into the 9.0 branch if we still can. Comment at: clang-tools-extra/clan

[PATCH] D66031: clangd: use -j for background index pool

puremourning created this revision. puremourning added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using -bac