[PATCH] D65999: [ASTImporter] Import additional flags for functions.

This revision was automatically updated to reflect the committed changes. balazske marked an inline comment as done. Closed by commit rL368655: [ASTImporter] Import additional flags for functions. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5373 +INSTANTIATE_TEST_CASE_P(ParameterizedTests, SVEBuiltins, +::testing::Values(ArgVector{"-target", a_sidor

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske updated this revision to Diff 214772. balazske added a comment. - Moved SVEBuiltins test instantiation to non-different position. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65999/new/ https://reviews.llvm.org/D65999 Files: clang/lib/

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Balazs, The change looks good. I think it can be committed after an unrelated part is removed. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5373 +INSTANTIA

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the function

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske updated this revision to Diff 214585. balazske added a comment. - Using StringRef, added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65999/new/ https://reviews.llvm.org/D65999 Files: clang/lib/AST/ASTImporter.cpp clang/unit

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the function

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

a_sidorin added a comment. Hello Balazs, The patch looks good in general. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the functio

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the function

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

martong added a comment. LGTM, but I don't exactly see how the first test is related. Could you please explain? Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of i

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. At AST import of function delcarations import the flags for def