[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

2019-08-08 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese closed this revision. Bigcheese added a comment. Fixed and committed as r368381. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65989/new/ https://reviews.llvm.org/D65989 ___ cfe-commits mailing list cfe-com

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

2019-08-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp:577 +TEST(MinimizeSourceToDependencyDirectivesTest, CxxModules) { +SmallVector Out; +SmallVector Tokens; Looks like it's not indented according to clang-

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

2019-08-08 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65989/new/ https://reviews.llvm.org/D65989 ___ cfe-commit

[PATCH] D65989: [clang-scan-deps] Add minimizer support for C++20 modules.

2019-08-08 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese created this revision. Bigcheese added a reviewer: arphaman. Herald added subscribers: tschuett, dexonsmith. Herald added a project: clang. This only adds support to the minimizer, it doesn't actually capture the dependencies yet. Repository: rC Clang https://reviews.llvm.org/D6598