This revision was automatically updated to reflect the committed changes.
Closed by commit rL368602: [clang-doc] Generate HTML links for children
namespaces/records (authored by DiegoAstiazaran, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior t
juliehockett accepted this revision.
juliehockett marked an inline comment as done.
juliehockett added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250
+ // The resulting path is "../../../A/B/D" ins
DiegoAstiazaran updated this revision to Diff 21.
DiegoAstiazaran added a comment.
Change the implementation of computeRelativePath
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65987/new/
https://reviews.llvm.org/D65987
Files:
clang-tools-extra/clang-doc/HTMLGenerator.cpp
clan
DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250
+ // The resulting path is "../../../A/B/D" instead of a "../D". It is correct
+ // but it would be better to have the shorter
DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250
+ // The resulting path is "../../../A/B/D" instead of a "../D". It is correct
+ // but it would be better to have the shorter
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250
+ // The resulting path is "../../../A/B/D" instead of a "../D". It is correct
+ // but it would be better to have the shorter version.
StringRef Dir = Directory;
--
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: juliehockett, jakehehrlich.
DiegoAstiazaran added a project: clang-tools-extra.
Path is now stored in the references to the child while serializing, then this
path is used to generate the relative path in the HTML generator.
