[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

2019-08-08 Thread Johan Vikström via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL368291: [clangd] Added semantic highlighting support for primitives. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscri

[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

2019-08-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, just a nit. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:138 +// Builtins must be special cased as they do not have a TagDecl. +if (const auto

[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

2019-08-08 Thread Johan Vikström via Phabricator via cfe-commits
jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds a new HighlightingKind "Primitive". Adds a special case for TypeLocs that have an underlying TypePtr