[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea abandoned this revision. aganea added a comment. Please see the other reviews I've sent. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65906/new/ https://reviews.llvm.org/D65906 ___ cfe-commits mailing list cf

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea added a comment. In D65906#1622209 , @arphaman wrote: > @aganea These are not just any invisible characters that you have, this is > the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of > the file (`Lexer::InitLexer`). The mi

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

arphaman added a comment. @aganea These are not just any invisible characters that you have, this is the UTF8 BOM. Clang's Lexer skips over them if they're in the beginning of the file (`Lexer::InitLexer`). The minimizer should do the same thing, so ideally you would factor out the BOM detectio

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

dexonsmith added a comment. In D65906#1621542 , @aganea wrote: > In D65906#1620034 , @arphaman wrote: > > > Regarding the invisible characters before `#ifdef`, are you sure that's the > > right behavior? > > > Shou

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea added a comment. In D65906#1620034 , @arphaman wrote: > Regarding the invisible characters before `#ifdef`, are you sure that's the > right behavior? Should we then copy these invisible characters to the minimized output? Believe it or not, thes

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

arphaman added a comment. Thanks for figuring out these issues! It looks like you're fixing several edge cases, would you mind splitting the patch up for easier review? Regarding the invisible characters before `#ifdef`, are you sure that's the right behavior? If you run the preprocessor over y

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. This patch fixes: 1. Invisible characters that come just before #include, such as #ifndef. ( were hidden, depending on the display loca