This revision was automatically updated to reflect the committed changes.
Closed by commit rL368186: Code completion should not ignore default parameters
in functions. (authored by sammccall, committed by ).
Herald added subscribers: llvm-commits, ilya-biryukov.
Herald added a project: LLVM.
Chan
usaxena95 updated this revision to Diff 213927.
usaxena95 added a comment.
Formatted new test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65866/new/
https://reviews.llvm.org/D65866
Files:
clang-tools-extra/clangd/CodeCompletionStrings.cpp
c
usaxena95 updated this revision to Diff 213926.
usaxena95 marked 3 inline comments as done.
usaxena95 added a comment.
Added tests in CodeCompletionStringsTests.cpp
Resolved comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65866/new/
https:/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:35
+void appendCodeCompletionString(const CodeCompletionString &CCS, std::string
*Out) {
+ for (c
usaxena95 updated this revision to Diff 213871.
usaxena95 added a comment.
Removed unused include of logger.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65866/new/
https://reviews.llvm.org/D65866
Files:
clang-tools-extra/clangd/CodeCompletionS
usaxena95 created this revision.
usaxena95 added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous.
Herald added a project: clang.
Inorder to display the default arguments we must process the
CK_Optional chunks of CodeCompletionString while creating the Sign
