MaskRay added a comment.
One thing I (a zsh user) feel inconvenient about `-###` is that...
% echo -###
zsh: bad pattern: -###
% echo '-###'
-###
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65839/new/
https://reviews.llvm.org/D65839
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
I'm fine with `-###-verbatim`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65839/new/
https://reviews.llvm.org/D65839
_
compnerd added inline comments.
Comment at: clang/include/clang/Driver/Options.td:333
HelpText<"Print (but do not run) the commands to run for this
compilation">;
+def _HASH_HASH_HASH_VERBATIM : Flag<["-"], "###-verbatim">,
+Flags<[DriverOption, CoreOption]>,
--
smeenai updated this revision to Diff 213773.
smeenai edited the summary of this revision.
smeenai added a comment.
Output to stdout
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65839/new/
https://reviews.llvm.org/D65839
Files:
clang/include/cl
smeenai added a comment.
I'm not tied to the name `-###-verbatim` and am open to suggestions if anyone
can think of something better.
My troll suggestion was `-`, but @compnerd didn't like that for some
reason...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
smeenai created this revision.
smeenai added reviewers: compnerd, phosek, rnk.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
smeenai added a parent revision: D65838: [Driver] Use enumeration for quoting
mode. NFC.
When writing driver tests, it's useful to have a way to ou