This revision was automatically updated to reflect the committed changes.
Closed by commit rL368058: Fixed toHalfOpenFileRange assertion fail (authored
by SureYeaah, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry, should have accepted this in the last round. Great stuff, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65754/new/
https
SureYeaah updated this revision to Diff 213614.
SureYeaah added a comment.
use fileID instead of hash in map
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65754/new/
https://reviews.llvm.org/D65754
Files:
clang-tools-extra/clangd/SourceCode.cpp
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:316
+ // Expand begin of Expansion range till the top and map with file id hash.
+ llvm::DenseMap BeginExpansions;
+ SourceRange BeginExpansion = ExpansionRange.getBegin();
sa
SureYeaah updated this revision to Diff 213599.
SureYeaah marked 8 inline comments as done.
SureYeaah added a comment.
Addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65754/new/
https://reviews.llvm.org/D65754
Files:
clan
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:307
+// the same file id.
+static SourceRange getExpansionRangeInSameFiles(SourceLocation Loc,
+const SourceManager &SM,
nit: `get
SureYeaah updated this revision to Diff 213583.
SureYeaah added a comment.
Implemented function to get expansion range such that ends are both in the same
file id.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65754/new/
https://reviews.llvm.org/D
SureYeaah created this revision.
SureYeaah added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov.
Herald added a project: clang.
- Removed assumption that begin and end need to be in same file id.
- Fixes the crash at https://github.com/clang
