arsenm abandoned this revision.
arsenm added a comment.
Herald added a project: All.
Looks like __builtin_elementwise_* now exist to handle some of these operations
for arbitrary vector elements
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65753/new/
https://reviews.llvm.org/D65753
_
scanon added a comment.
(Ideally we would just call them e.g. __builtin_floor, but that would be
source-breaking. __builtin_tgmath_floor seems like a good compromise.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65753/new/
https://reviews.llvm.org/D65753
__
scanon added a comment.
Strongly agree with what @rjmccall said. If we can make these generic builtins
instead of ending up with O(100) variants of each math operation, that would
make life immensely nicer.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65753/new/
https://reviews.llvm.
rjmccall added a comment.
Hmm, sorry, that's a C++ spec, and it looks like the (abandoned) C attempt at
data parallelism (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2081.htm)
doesn't introduce vector types.
Talking about it internally, I think there are two reasonable approaches:
- Add a
rjmccall added a comment.
You might want to look into ISO/IEC TS 19570 - 2018 to see what they're
thinking. If it looks like there's a potential conflict, then maybe these
should have an OpenCL-specific prefix on them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65753/new/
https://
rjmccall added a comment.
Hmm. I think there are two reasonable concerns here, both arising from the
fact that these names occupy (the builtin namespace parallel to) a namespace
that the committee might want to occupy in the future:
- Is a `v2fN` suffix sufficiently likely to avoid interfering
arsenm created this revision.
arsenm added reviewers: rjmccall, Anastasia, yaxunl, rsmith.
Herald added a subscriber: wdng.
arsenm added a parent revision: D65597: WIP: Builtins: Start adding half
versions of math builtins.
This will avoid hacks in the OpenCL builtin library.
https://reviews.ll
