[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL371032: [Sema] Refactor LookupVisibleDecls. NFC (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agreed, this seems fine as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65752/new/ https://reviews.llvm.org/D65752 ___

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov added a subscriber: doug.gregor. ilya-biryukov added a comment. In D65752#1623914 , @sammccall wrote: > This looks reasonable to me, there are a couple of variations you might think > about: > > - also treat QualifiedNameLookup as an option,

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

sammccall added a comment. This looks reasonable to me, there are a couple of variations you might think about: - also treat QualifiedNameLookup as an option, and override in places with an RAII pattern like `ScopedOverride Unqual(QualifiedNameLookup, false)` (why don't we have a class like th

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov added a comment. This is just a proposal, there are probably other ways to reach better readability, e.g. group some of those parameters into a struct. But let me know what you think, happy to refactor in a slightly different manner or simply drop this revision. Repository: rG

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov updated this revision to Diff 213371. ilya-biryukov added a comment. - Remove accidental change from revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65752/new/ https://reviews.llvm.org/D65752 Files: clang/lib/Sema/SemaLookup

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. We accumulated some configuration parameters for LookupVisibleDecls that are being passed unchanged to recursive calls, e.g. LoadExt