[PATCH] D65665: Support for attributes on @class declarations

2019-08-12 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Have you looked through the attributes that can be written on `@interface`s and verified that they're all sensible to write on a `@class`? It's not hard to imagine that *some* of them should be diagnosed when added to a non-definition. Repository: rC Clang CHANGES

[PATCH] D65665: Support for attributes on @class declarations

2019-08-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I don't think I know enough about ObjC semantics to say much about the language design aspects of this patch. Comment at: clang/include/clang/Parse/Parser.h:1496 + DeclGroupPtrTy ParseObjCAtClassDeclaration(SourceLocation atLoc, +

[PATCH] D65665: Support for attributes on @class declarations

2019-08-02 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, arphaman, rjmccall. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This is useful to make availability checking work with forward declarations, but there also seem to be other att