SureYeaah marked an inline comment as done.
SureYeaah added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:314
while (!FileRange.getBegin().isFileID()) {
-assert(!FileRange.getEnd().isFileID() &&
- "Both Begin and End should be MacroIDs.");
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:373
+if(!Range)
+ return SelectionTree::Unselected;
dlog("{1}claimRange: {0}", Range->printToString(SM), indent());
This isn't a sufficient fix, there are 5 callsite
SureYeaah created this revision.
SureYeaah added reviewers: sammccall, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov.
Herald added a project: clang.
- Still need to investigate why this is happening.
- Fixes the crash described at https://github.com/clangd/clang
