[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

This revision was automatically updated to reflect the committed changes. Closed by commit rL367864: Move LangStandard*, InputKind::Language to Basic (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added a comment. I've now submitted the lldb patch to reflect the `LangStandard.h` move. It turns out the part of isl (included in polly) that uses `InputKind::C` isn't even compiled inside the llvm tree. Nonetheless, I've submitted a patch upstream

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 213243. ro marked 2 inline comments as done. ro added a comment. - Restrict enum class Languge to uint8_t to save space. - Filter patch through clang-format-diff.py Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/ https://

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > ro wrote: > > rnk wrote: > > > Is it feasible to make this an `enum class`? I'm worried about namespace > >

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good either way. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, ro wrote: > rnk wrote: >

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro marked 2 inline comments as done. ro added inline comments. Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, rnk wrote: > Is it feasible to make this an `enum class`? I'm worried about namespace

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro updated this revision to Diff 212992. ro marked an inline comment as done. ro added a comment. Change Language to enum class. Tested as before. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65562/new/ https://reviews.llvm.org/D65562 Files: include/clang/Ba

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

rnk added a comment. Thanks! Comment at: include/clang/Basic/LangStandard.h:19 +/// standard and possible actions. +enum Language { + Unknown, Is it feasible to make this an `enum class`? I'm worried about namespace clashes on these otherwise very short names

[PATCH] D65562: Move LangStandard*, InputKind::Language to Basic

ro created this revision. ro added reviewers: rsmith, rnk. Herald added subscribers: fedor.sergeev, Anastasia, mgorny, jyknight. Herald added a reviewer: bollu. Herald added a project: clang. This patch is a prerequisite for using `LangStandard` from `Driver` in https://reviews.llvm.org/D64793.