[PATCH] D65543: Use library basenames when autolinking on Windows

2019-08-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. I kind of like the current behavior since it's consistent with how resource dirs are passed to cc1, and how __FILE__ expands if you give a relative work to clang, and how debug info paths look if you pass relative paths to clang. Repository: rG LLVM Github Monorepo C

[PATCH] D65543: Use library basenames when autolinking on Windows

2019-08-01 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I'll look into that. I also noticed that check-ubsan fails. I think we should also change clang's driver to add this libpath when it invokes the linker, so that this works transparently when using the GCC-style driver. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D65543: Use library basenames when autolinking on Windows

2019-07-31 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. The idea behind embedding the path was that these objects are usually not distributed, so things usually just work. Is there some other way that we could arrange for the linker to search the sanitizer library directory automatically? Maybe we could add the path to one of t

[PATCH] D65543: Use library basenames when autolinking on Windows

2019-07-31 Thread Reid Kleckner via Phabricator via cfe-commits
rnk created this revision. rnk added reviewers: russell.gallop, thakis, pcc. Herald added a subscriber: srhines. Herald added a project: clang. Otherwise we embed a potentially absolute and potentially relative path to clang's resource directory into the object file. Object files with paths embedd