This revision was automatically updated to reflect the committed changes.
Closed by commit rL370928: Avoid assemble step in verbose-output-quoting.c
(authored by yuanfang, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65527/new/
https://reviews.llvm.org/D65527
__
ychen updated this revision to Diff 218588.
ychen added a comment.
Address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65527/new/
https://reviews.llvm.org/D65527
Files:
clang/test/Driver/verbose-output-quoting.c
Index: clang/test/Dr
ychen added a comment.
> Would that work for this test also?
Yes, that sounds good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65527/new/
https://reviews.llvm.org/D65527
___
cfe-commits mailing lis
hans added a comment.
Sorry, I should have caught this in the original review.
Normally tests in Driver/ use the -### flag. That way it doesn't invoke the
frontend at all, it just shows how it would invoke it. Would that work for this
test also?
Repository:
rG LLVM Github Monorepo
CHANGES
ychen created this revision.
ychen added a reviewer: hans.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D65527
Files:
clang/test/Driver/verbose-output-quoting.c
Index: clang/test/Driver/verbose-output-qu
