[PATCH] D65433: [clangd] DefineInline action availability checks

thakis added a comment. The test fails in Windows: http://45.33.8.238/win/1112/step_7.txt Ptal, and if it takes a while to investigate please revert while you look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/

[PATCH] D65433: [clangd] DefineInline action availability checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG74d39a42f109: [clangd] DefineInline action availability checks (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D65433?vs=222158&id=226394#toc Repository: rG LLVM Github Mono

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 222158. kadircet added a comment. - Rebase and bail out on methods inside templated classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221947. kadircet added a comment. - Use canonical decl when checking visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refac

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221911. kadircet added a comment. - Revert miscommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221910. kadircet added a comment. - Rebase and update testhelpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/Def

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221314. kadircet marked 7 inline comments as done. kadircet added a comment. - Rebase on top of D67748 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:183 +/// a.h: +/// void foo() { return ; } +/// hokein wrote: > kadircet wrote: > > hokein wrote: > > > kadircet wrote: > > > > hokein wrote: > > > > > now we

[PATCH] D65433: [clangd] DefineInline action availability checks

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good with a few nits. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:183 +/// a.h: +/// void foo() { return ; } +/// kadircet

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:183 +/// a.h: +/// void foo() { return ; } +/// hokein wrote: > kadircet wrote: > > hokein wrote: > > > now we get a potential ODR violation in this example, m

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221270. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-ex

[PATCH] D65433: [clangd] DefineInline action availability checks

hokein added a comment. mostly good to me, a few more comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:183 +/// a.h: +/// void foo() { return ; } +/// kadircet wrote: > hokein wrote: > > now we get a potential ODR violation in t

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 220821. kadircet marked 17 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-e

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:78 +// function decl. Skips local symbols. +llvm::DenseSet getNonLocalDeclRefs(const FunctionDecl *FD, + ParsedAST &AST) { ---

[PATCH] D65433: [clangd] DefineInline action availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:65 +const FunctionDecl *getSelectedFunction(const SelectionTree::Node *SelNode) { + const ast_type_traits::DynTypedNode &AstNode = SelNode->ASTNode; + if (const FunctionDecl *FD

[PATCH] D65433: [clangd] DefineInline action availability checks

arphaman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:192 + Intent intent() const override { return Intent::Refactor; } + std::string title() const override { return "Inline function definition"; } + sammccall wro

[PATCH] D65433: [clangd] DefineInline action availability checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:192 + Intent intent() const override { return Intent::Refactor; } + std::string title() const override { return "Inline function definition"; } + kadircet wro

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet marked an inline comment as done. kadircet added a comment. In D65433#1661865 , @arphaman wrote: > When fully implemented, will define inline tweak work with C++ methods in > classes as well? Yes you can see an example of it in the tests provid

[PATCH] D65433: [clangd] DefineInline action availability checks

arphaman added a comment. When fully implemented, will define inline tweak work with C++ methods in classes as well? E.g. HEADER: class Foo { void foo(); } CPP: #include "Header.h" void Foo::foo() {} becomes: HEADER: class Foo { void foo() { } } CPP: #include "Header.h"

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 218936. kadircet marked 4 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: cla

[PATCH] D65433: [clangd] DefineInline action availability checks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:59 + +void checkAvailable(StringRef ID, llvm::StringRef Input, bool Available, +const llvm::StringMap &AdditionalFiles) { This function, and all the

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 216815. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang-too

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Introduces DefineInline action and initial version of availability checks. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65