[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL368491: [OpenMP] Add support for close map modifier in Clang (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE |

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added inline comments. This revision is now accepted and ready to land. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. Looks fine to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev accepted this revision. ABataev added a comment. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. @Hahnfeld I have merged the tests from the previous patch as per Alexey's suggestion - with minor changes to make them pass. Let me know if this now addresses your previous comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/n

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea updated this revision to Diff 212821. gtbercea added a comment. - Improve test. - Add tests from previous patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/Ope

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604562 , @kkwli0 wrote: > In D65341#1604561 , @gtbercea wrote: > > > In D65341#1604440 , @ABataev wrote: > > > > > In D65341#1604411

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. In D65341#1604562 , @kkwli0 wrote: > In D65341#1604561 , @gtbercea wrote: > > > In D65341#1604440 , @ABataev wrote: > > > > > In D65341#1604411

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

kkwli0 added a comment. In D65341#1604561 , @gtbercea wrote: > In D65341#1604440 , @ABataev wrote: > > > In D65341#1604411 , @Hahnfeld > > wrote: > > > > > There's already D

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea added a comment. In D65341#1604440 , @ABataev wrote: > In D65341#1604411 , @Hahnfeld wrote: > > > There's already D55892 with a better set > > of tests, including `target

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev added a comment. In D65341#1604411 , @Hahnfeld wrote: > There's already D55892 with a better set of > tests, including `target enter data` / `target exit data`. Better to merge those two patches into one. Repo

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

Hahnfeld added subscribers: saghir, Hahnfeld. Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. There's already D55892 with a better set of tests, including `target enter data` / `target exit dat

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 ___ cfe-commits ma

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea updated this revision to Diff 212011. gtbercea added a comment. - Improve test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65341/new/ https://reviews.llvm.org/D65341 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/target_data_codegen.cpp Ind

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE |

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7695 Flags &= ~(OMP_MAP_TO | OMP_MAP_FROM | OMP_MAP_ALWAYS | - OMP_MAP_DELETE); + OMP_MAP_DELETE | OMP_MAP_CLOSE); Why? R

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. This patch adds support for the close map modifier in Clang. This ensures that the new map type is marked