[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368766: [analyzer] exploded-graph-rewriter: Open the converted graph immediately. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846 +print(' $ dot -Tsvg input.dot -o output.svg') +print() +write_temp_file('.dot', self.output()) --

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like the HTML output, thanks! Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:846 +print(' $ dot -Tsvg input.dot -o output.svg') +

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

Charusso added a comment. In D65250#1601187 , @NoQ wrote: > In D65250#1600776 , @grandinj wrote: > > > There is no need to wrap SVG in HTML if you want to display it in a > > web-browser > > > I guess it's worth it

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ added a comment. In D65250#1600776 , @grandinj wrote: > There is no need to wrap SVG in HTML if you want to display it in a > web-browser, you can just open the web-browser explicitly, they already > support opening SVG, use something like > > webb

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

grandinj added a comment. There is no need to wrap SVG in HTML if you want to display it in a web-browser, you can just open the web-browser explicitly, they already support opening SVG, use something like webbrowser.open_new(url) i.e. https://docs.python.org/2/library/webbrowser.html CHAN

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ updated this revision to Diff 211640. NoQ added a comment. Polish wording a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65250/new/ https://reviews.llvm.org/D65250 Files: clang/test/Analysis/exploded-graph-rewriter/lit.local.cfg clang/utils/analyzer/exploded-graph-rewrite

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ updated this revision to Diff 211639. NoQ added a comment. Make it a soft failure when graphviz is not installed. Display a friendly warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65250/new/ https://reviews.llvm.org/D65250 Files: clang/test/Analysis/exploded-graph-rewrit

[PATCH] D65250: [analyzer] exploded-graph-rewriter: Improve user-friendliness.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Change the default behavior: the tool