[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

2019-07-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL367167: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

2019-07-26 Thread Nico Weber via Phabricator via cfe-commits
thakis marked an inline comment as done. thakis added a comment. Thanks, landing with your suggestion applied. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65227/new/ https://reviews.llvm.org/D65227 ___ cfe-commits mailing list cfe-commits

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

2019-07-25 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. I am surprised this works as well as it does, but tests seem to indicate it does, so... LG (minus potentially reducing some duplication :) Comment at: clang/lib/Format/Token

[PATCH] D65227: clang-format: Support `if CONSTEXPR` if CONSTEXPR is a macro.

2019-07-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: klimek. This is like r305666 (which added support for `if constexpr`) except that it allows a macro name after the if. This is slightly tricky for two reasons: 1. r305666 didn't add test coverage for all cases where it added a kw_constexpr,