[PATCH] D65149: [Format] Add test demonstrating PR42722

2019-08-11 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5184 + "c++;\n" + "d++\n" + " });\n" MyDeveloperDay wrote: > modocache wrote: > > This is a passing test that demonstrates that t

[PATCH] D65149: [Format] Add test demonstrating PR42722

2019-08-10 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5184 + "c++;\n" + "d++\n" + " });\n" modocache wrote: > This is a passing test that demonstrates that the indentation of `c+

[PATCH] D65149: [Format] Add test demonstrating PR42722

2019-07-26 Thread Brian Gesiak via Phabricator via cfe-commits
modocache marked an inline comment as done. modocache added a comment. Sure thing! Just to be clear: this test doesn't fail, it passes. My intention was to commit this, then commit a patch that improved the indentation behavior, which would also include a change to the test that demonstrated the

[PATCH] D65149: [Format] Add test demonstrating PR42722

2019-07-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. We don't normally commit a failing test alone, otherwise the build machines will be broken until it gets fixed.. just add this test with your fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65149/new/ https://rev

[PATCH] D65149: [Format] Add test demonstrating PR42722

2019-07-23 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: ank, klimek, acoomans. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=42722 describes what I believe to be a bug in lambda formatting. If it is indeed a bug, I'd like to commit this test that reliably reproduces it.