[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rL368454: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOp

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || xazax.hun wrote: > gribozavr wrote: >

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || mgehre wrote: > xazax.hun wrote: > > I

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

mgehre added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || xazax.hun wrote: > If we want to relax th

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun updated this revision to Diff 212207. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Rebase, add the results of testing on real world projects to the description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65127/new/ https://reviews.llvm.org/D65

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6581 +if (!Callee->getIdentifier()) { + auto OO = Callee->getOverloadedOperator(); + return OO == OverloadedOperatorKind::OO_Subscript || ---

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun updated this revision to Diff 211583. xazax.hun added a comment. - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65127/new/ https://reviews.llvm.org/D65127 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/warn-lifetime-analysis-nocfg.cpp Index: clang/test/Sema/w

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun added a comment. I have run this successfully on ~192 open source projects. The results so far: 1. https://github.com/ANTsX/ANTs/blob/master/Examples/sccan.cxx#L2899 /home/tgahor/data/projects/ANTs/Examples/sccan.cxx:2899:34: warning: object backing the pointer will be destroyed

[PATCH] D65127: Even more warnings utilizing gsl::Owner/gsl::Pointer annotations

xazax.hun created this revision. xazax.hun added reviewers: gribozavr, rsmith, mgehre. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, Szelethus, dkrupp, rnkovacs. xazax.hun added a parent revision: D65120: More warnings regarding gsl::Pointer and gsl