[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

2019-07-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366744: [Driver] Set the default win32-macho debug format to DWARF (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

2019-07-22 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.h:81 /// Set CodeView as the default debug info format. Users can use -gcodeview /// and -gdwarf to override the default. Let's update the comment. CHANGES SINCE LAST ACTI

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

2019-07-22 Thread Davide Italiano via Phabricator via cfe-commits
davide accepted this revision. davide added a comment. Minor otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65116/new/ https://reviews.llvm.org/D65116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D65116: [Driver] Set the default win32-macho debug format to DWARF

2019-07-22 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. vsk added reviewers: ahatanak, JDevlieghere, friss. Herald added a subscriber: dexonsmith. rdar://53267670 https://reviews.llvm.org/D65116 Files: clang/lib/Driver/ToolChains/MSVC.h clang/test/Misc/win32-macho.c Index: clang/test/Misc/win32-macho.c ==