[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL367008: [OpenCL] Rename lang mode flag for C++ mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(openclcpp, "CLC++") svenvh wrote: > It surprised me that t

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(openclcpp, "CLC++") It

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia added a comment. In D65102#1597651 , @kpet wrote: > Hmm, maybe we need to make sure that one of the tests is using a C++ feature > and building with `CLC++`. This would have caught the mistake. That's right! The only test we had wasn't using a

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia updated this revision to Diff 211320. Anastasia added a comment. Use -cl-std=CLC++ spelling for test/CodeGenOpenCLCXX/addrspace-with-class.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65102/new/ https://reviews.llvm.org/D65102 Files: include/clang/Driver/Options.td in

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

kpet added a comment. Hmm, maybe we need to make sure that one of the tests is using a C++ feature and building with `CLC++`. This would have caught the mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65102/new/ https://reviews.llvm.org/D65102

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(opencl20, "CLC++") kpet wrote: > Shouldn't this be `opencl

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia updated this revision to Diff 211315. Anastasia added a comment. - Fixed `LANGSTANDARD_ALIAS_DEPR` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65102/new/ https://reviews.llvm.org/D65102 Files: include/clang/Driver/Options.td include/clang/Frontend/LangStandards.def li

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

kpet added a comment. Thanks for doing this! Comment at: include/clang/Frontend/LangStandards.def:177 LANGSTANDARD_ALIAS_DEPR(opencl20, "CL2.0") +LANGSTANDARD_ALIAS_DEPR(opencl20, "CLC++") Shouldn't this be `openclcpp`? CHANGES SINCE LAST ACTION https://

[PATCH] D65102: [OpenCL] Rename lang mode flag for C++ mode

Anastasia created this revision. Anastasia added reviewers: svenvh, neil.hickey, kpet. Herald added subscribers: ebevhan, yaxunl. This suggestion was made in https://reviews.llvm.org/D64418?id=210101#inline-579453 but I am changing this standalone here. I see two benefits for this rename: - Al