[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2020-01-21 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Hey Saar, I have temporarily reverted this because it broke the LLDB bots. Please run the LLDB test suite when you make changes to the AST importer & keep an eye on the bots when you re-land this. Thanks! commit 62e4b501ab3bc4c5815a179fdd2c4b49574506c1 (HEAD -> m

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2020-01-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I've left some comments suggesting how to rebase this on rGa42fd84cff265b7e9faa3fe42885ee171393e4db ; otherwise, some mino

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2020-01-16 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 238478. saar.raz marked 21 inline comments as done. saar.raz added a comment. Address CR comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65042/new/ https://reviews.llvm.org/D65042 Files: .gitignore

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2020-01-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I think this might work out more cleanly if we represented a constrained auto type as a `ConstrainedType` node wrapping an `AutoType` node rather than putting both things into the same object. (This will become more pressing if/when C++ starts allowing, for example, cons

[PATCH] D65042: [Concept] Placeholder constraints and abbreviated templates

2019-07-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. `ASTImporter.cpp` and `ASTStructuralEquivalence.cpp` looks good to me! Comment at: lib/AST/ASTImporter.cpp:1286 - return Importer.getToContext().getAutoType(*ToDeducedTypeOrErr, - T->getKeyword(), -