[PATCH] D65030: [clang-doc] Add second index for sections within info's content

This revision was automatically updated to reflect the committed changes. Closed by commit rL368209: [clang-doc] Add second index for sections within info's content (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213991. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/unittests/clang-doc/HTM

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213706. DiegoAstiazaran added a comment. Changed `JumpToSection` in Index struct and `genHTML(const Index &Index, ...)` function to `llvm::Optional`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > DiegoAstiazaran wrote: > > juliehockett wrote: > > > Formatting is

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213509. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a parent revision: D65690: [clang-doc] Add index in each info html file. DiegoAstiazaran added a comment. Changed depe

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + DiegoAstiazaran wrote: > juliehockett wrote: > > Formatting is a bit weird for sublists > Fi

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. This looks awesome! Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:257 +genTypeReference(const Reference &Type, StringRef CurrentDirectory, +

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:47-52 + + Namespaces + Records + Functions + OneFunction + juliehockett wrote: > Formatting is a bit weird for sublists Fixed by D65005. It will be

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 211869. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Add comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenera

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. Looks mostly good to me, with a small formatting thing Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:490 Out.emplace_back(llvm::make_unique(HTMLTag::TAG_H3, I.Name)); + Out.back()->Attributes.try_emplace("id", +

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. This new index contains links to the main section of infos: Namespaces, Records, Functions, Enum