[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

2019-07-19 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In D65009#1594009 , @pcc wrote: > Sorry, just realized this. If I do > > clang++ -c -flto a.cpp # "split" > clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split > clang++ a.o b.o > > > this should fail, right? If

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

2019-07-19 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. Sorry, just realized this. If I do clang++ -c -flto a.cpp # "split" clang++ -c -flto=thin b.cpp -fwhole-program-vtables # non-split clang++ a.o b.o this should fail, right? If I'm not mistaken, this patch series will cause this to succeed. I think we need to change th

[PATCH] D65009: [LTO] Don't mark regular LTO units with EnableSplitLTOUnit

2019-07-19 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, inglorion, Prazek, mehdi_amini. Herald added a project: clang. LTO Unit splitting does not apply to regular LTO modules, only ThinLTO (which must be consistently split into regular an