[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran abandoned this revision. DiegoAstiazaran added a comment. D65690 replaces this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 ___ cfe-comm

[PATCH] D65003: [clang-doc] Add index in each info html file

jakehehrlich added a comment. I think everything but the implementation of `genIndex` being confusing looks good to me. I haven't actually groked how that code works yet other than the fact that it generates the index tree that I expect and all the surrounding code looks good to me. I understan

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:337-346 + + A + B + C + + D + E juliehockett wrote: > The indentation here seems a bit off Fixed by D65005. CHANGES SINCE LAST ACTION https://r

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran updated this revision to Diff 211866. DiegoAstiazaran marked 3 inline comments as done. DiegoAstiazaran added a comment. Rebase and add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65003/new/ https://reviews.llvm.org/D65003 Files: clang-tools-extra/clang-do

[PATCH] D65003: [clang-doc] Add index in each info html file

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Generators.h:28 + static Index genIndex(const std::vector> &Infos); + Add a comment here indicating that this should be created before calling any `generateDocForInfo`s. Also add a fi

[PATCH] D65003: [clang-doc] Add index in each info html file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, mgorny. An index structure is created while reducing the infos. This is then pas