This revision was automatically updated to reflect the committed changes.
Closed by commit rL366577: [clangd] Provide a way to publish highlightings in
non-racy manner (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to c
ilya-biryukov updated this revision to Diff 210823.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Group PublishFn with onMainAST
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64985/new/
https://reviews.llvm.org/D6
ilya-biryukov added a comment.
Thanks for all the suggestions. This is ready for the next round now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64985/new/
https://reviews.llvm.org/D64985
___
cfe-com
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Awesome, I think this is in better shape than before highlighting was added.
Comment at: clang-tools-extra/clangd/TUScheduler.h:102
const
ilya-biryukov updated this revision to Diff 210808.
ilya-biryukov added a comment.
- Remove a leftover comment from the previous version
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64985/new/
https://reviews.llvm.org/D64985
Files:
clang-tools-
ilya-biryukov updated this revision to Diff 210807.
ilya-biryukov added a comment.
- Update usage of DiagsMu in a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64985/new/
https://reviews.llvm.org/D64985
Files:
clang-tools-extra/clangd/Cl
ilya-biryukov updated this revision to Diff 210805.
ilya-biryukov added a comment.
- Use the same mechanism for diagnostics
- Change typedef to function)>
- Update a comment
- s/PublishResults/PublishFn
- Reformat
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews
sammccall added a comment.
I think this is the right design. As mentioned offline, I think we can now move
the onDiagnostics call out from TUScheduler into ClangdServer (and remove
onDiagnostics from the callbacks interface).
This is a better layer because the diagnostics callback model is reall
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, javed.absar.
Herald added a project: clang.
By exposing a callback that can guard code publishing results of
'onMainAST' callback in the same manner we gu
