This revision was automatically updated to reflect the committed changes.
sepavloff marked an inline comment as done.
Closed by commit rL367779: [Parser] Emit descriptive diagnostic for misplaced
pragma (authored by sepavloff, committed by ).
Herald added a project: LLVM.
Herald added a subscriber
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64932/new/
https://reviews.llvm.org/D64932
___
sepavloff marked 2 inline comments as done.
sepavloff added inline comments.
Comment at: clang/lib/Basic/TokenKinds.cpp:15
#include "llvm/Support/ErrorHandling.h"
+#include
using namespace clang;
rjmccall wrote:
> This is no longer necessary, right?
Sure, remo
sepavloff updated this revision to Diff 213023.
sepavloff added a comment.
Updated patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64932/new/
https://reviews.llvm.org/D64932
Files:
clang/include/clang/Basic/DiagnosticParseKinds.td
clang/li
rjmccall added inline comments.
Comment at: clang/lib/Basic/TokenKinds.cpp:15
#include "llvm/Support/ErrorHandling.h"
+#include
using namespace clang;
This is no longer necessary, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
sepavloff updated this revision to Diff 212188.
sepavloff added a comment.
Updated patch
Move logically independent changes to separate patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64932/new/
https://reviews.llvm.org/D64932
Files:
cla
rjmccall added inline comments.
Comment at: clang/lib/Basic/TokenKinds.cpp:55
+return std::strncmp(#X, "pragma_", sizeof("pragma_") - 1) == 0;
+#include "clang/Basic/TokenKinds.def"
+ default:
The right way to do this is to make a `PRAGMA_ANNOTATION` macro i
sepavloff added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64932/new/
https://reviews.llvm.org/D64932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
sepavloff created this revision.
sepavloff added reviewers: rsmith, rjmccall, erik.pilkington, ABataev.
Herald added a subscriber: dexonsmith.
Herald added a project: clang.
If a class or struct or union declaration contains a pragma that
is not valid in this context, compiler issues generic error
