[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-08-04 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sepavloff marked an inline comment as done. Closed by commit rL367779: [Parser] Emit descriptive diagnostic for misplaced pragma (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-08-02 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 ___

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-08-02 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/lib/Basic/TokenKinds.cpp:15 #include "llvm/Support/ErrorHandling.h" +#include using namespace clang; rjmccall wrote: > This is no longer necessary, right? Sure, remo

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-08-02 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 213023. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/li

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-07-31 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Basic/TokenKinds.cpp:15 #include "llvm/Support/ErrorHandling.h" +#include using namespace clang; This is no longer necessary, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-07-29 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 212188. sepavloff added a comment. Updated patch Move logically independent changes to separate patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 Files: cla

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-07-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/Basic/TokenKinds.cpp:55 +return std::strncmp(#X, "pragma_", sizeof("pragma_") - 1) == 0; +#include "clang/Basic/TokenKinds.def" + default: The right way to do this is to make a `PRAGMA_ANNOTATION` macro i

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-07-26 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64932/new/ https://reviews.llvm.org/D64932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64932: [Parser] Emit descriptive diagnostic for misplaced pragma

2019-07-18 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, erik.pilkington, ABataev. Herald added a subscriber: dexonsmith. Herald added a project: clang. If a class or struct or union declaration contains a pragma that is not valid in this context, compiler issues generic error