This revision was automatically updated to reflect the committed changes.
Closed by commit rL366448: [ASTUnit] Fix a regression in cached completions
(authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
sammccall added inline comments.
Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7
+// START-OF-LINE: Class
+// -- With preambles.
+// RUN: CINDEXTEST_EDITING=1 c-index-test -code-completion-at=%s:3:1 %s \
ilya-biryukov wrote:
> sammccall wrote:
ilya-biryukov added inline comments.
Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7
+// START-OF-LINE: Class
+// -- With preambles.
+// RUN: CINDEXTEST_EDITING=1 c-index-test -code-completion-at=%s:3:1 %s \
sammccall wrote:
> Nit: This (and t
kadircet accepted this revision.
kadircet added a comment.
LGTM from my side as well
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64918/new/
https://reviews.llvm.org/D64918
___
cfe-commits mailing lis
ilya-biryukov updated this revision to Diff 210555.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- s/preamble/cached completions (in tests)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64918/new/
https://reviews.l
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/Index/complete-qualified-with-preamble.cpp:7
+// START-OF-LINE: Class
+// -- With preambles.
+// RUN: CINDEXTEST_EDITING=1 c-index-test -code
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: clang.
After r345152 cached completions started adding namespaces after
nested name specifiers, e.g. in `some_name::^`
The CCC_Symbol indicates the completed
