This revision was automatically updated to reflect the committed changes.
Closed by commit rL368052: [AST] Traverse attributes inside DEF_TRAVERSE_DECL
macro (authored by ibiryukov, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
h
ilya-biryukov updated this revision to Diff 213558.
ilya-biryukov added a comment.
- Add the missing newline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64907/new/
https://reviews.llvm.org/D64907
Files:
clang/include/clang/AST/RecursiveASTVisi
gribozavr accepted this revision.
gribozavr added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/AST/RecursiveASTVisitorTest.cpp:107
+}
\ No newline at end of file
Please add a newline.
Repository:
rG LLVM Githu
ilya-biryukov updated this revision to Diff 212592.
ilya-biryukov added a comment.
- Reformat
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64907/new/
https://reviews.llvm.org/D64907
Files:
clang/include/clang/AST/RecursiveASTVisitor.h
clang/u
ilya-biryukov updated this revision to Diff 212591.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Add a test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64907/new/
https://reviews.llvm.org/D64907
Files:
clang/include/clan
gribozavr added a comment.
Looks like a good idea to me.
Regarding tests, I couldn't find existing tests that check order either. Seems
like you'd need to make some minimal infrastructure for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D649
ilya-biryukov added a comment.
Wanted to write unit tests, but couldn't find any that check traversal order.
I'm aware of `Tooling/RecursiveASTVisitorTests`, but they mostly check that
implicit nodes are visited.
Do we have other tests for traversals?
Repository:
rG LLVM Github Monorepo
CHA
ilya-biryukov updated this revision to Diff 210507.
ilya-biryukov added a comment.
- Visit attributes before visiting the Decl
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64907/new/
https://reviews.llvm.org/D64907
Files:
clang/include/clang/AS
ilya-biryukov created this revision.
ilya-biryukov added reviewers: rsmith, gribozavr.
Herald added a project: clang.
Instead of traversing inside the TraverseDecl() function.
Previously the attributes were traversed after Travese(Some)Decl
returns.
Logically attributes are properties of particul
