[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

2019-07-18 Thread Dan Gohman via Phabricator via cfe-commits
sunfish added inline comments. Comment at: cfe/trunk/include/clang/Basic/BuiltinsWebAssembly.def:34 TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") +TARGET_BUILTIN(__builtin_wasm_tls_base, "v*", "n", "bulk-memory") This can also be "p" for "p

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

2019-07-18 Thread Guanzhong Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL366475: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic (authored by quantum, committed by ). Changed prior to commit: https://reviews.llvm.org/D64900?vs=210469&id=210632#toc Repository: rL

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

2019-07-18 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum added a comment. In D64900#1590715 , @aheejin wrote: > What does this return when `__wasm_init_tls` has not been called? It returns `0`, which I think is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

2019-07-17 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. What does this return when `__wasm_init_tls` has not been called? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64900/new/ https://reviews.llv

[PATCH] D64900: [WebAssembly] Implement __builtin_wasm_tls_base intrinsic

2019-07-17 Thread Guanzhong Chen via Phabricator via cfe-commits
quantum created this revision. quantum added reviewers: tlively, aheejin, sbc100. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. Add `__builtin_wasm_tls_base` so that LeakSanitizer can find the thread-local b