This revision was automatically updated to reflect the committed changes.
Closed by commit rL366212: [OpenCL] Fixing sampler initialisations for C++
mode. (authored by neil.hickey, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
I expect the example from the bug is going to compile now:
https://bugs.llvm.org/show_bug.cgi?id=41009
Can you please close the bug after the commit.
C
neil.hickey created this revision.
neil.hickey added a reviewer: Anastasia.
Herald added a subscriber: yaxunl.
Sampler initialization from integer literal was broken in C++ mode for OpenCL.
Fixing to allow functions that take a sampler to take an integer and for
samplers to be initialized to int
