[PATCH] D64780: Disallow most calling convention attributes on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rL366617: Disallow most calling convention attributes on PS4 (authored by ssrivastava, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D64780: Disallow most calling convention attributes on PS4.

wristow accepted this revision. wristow added a comment. In D64780#1593624 , @aaron.ballman wrote: > LGTM aside from a nit. You should give other reviewers a chance to sign off > in case they have additional comments. LGTM too, once the line-length is

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:564 } + TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { +return (CC == CC_C) ? TargetInfo::CCCR

[PATCH] D64780: Disallow most calling convention attributes on PS4.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. You should give other reviewers a chance to sign off in case they have additional comments. Comment at: lib/Basic/Targets/OSTargets.h:56

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava updated this revision to Diff 210674. Sunil_Srivastava added a comment. - Adapted suggestion from Ried. - Cleaned up line ending and properties of the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 Files: include/c

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava added a comment. Pre-commit to change the wording and ID of warn_cconv_ignore has gone in in r366368. I will be shortly updating this review to account for that, and for other points raised here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: test/Sema/no_callconv.cpp:1 +// RUN: %clang_cc1 %s -triple x86_64-scei-ps4 -DPS4 -fsyntax-only -verify +// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -fsyntax-only -ver

[PATCH] D64780: Disallow most calling convention attributes on PS4.

aaron.ballman added inline comments. Comment at: test/Sema/no_callconv.cpp:1 +// RUN: %clang_cc1 %s -triple x86_64-scei-ps4 -DPS4 -fsyntax-only -verify +// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -fsyntax-only -verify Does this really need an svn:exec

[PATCH] D64780: Disallow most calling convention attributes on PS4.

wristow added reviewers: rnk, rjmccall. wristow added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1271 CCCR_Ignore, +CCCR_Error, }; rnk wrote: > I feel like perhaps a cleaner way of implementing this would be to have the > driver pa

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava removed reviewers: wristow, rnk, rjmccall. Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961 +def error_cconv_unsupported : Error< + "%0 calling convention not s

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rnk added a comment. Some suggestions, you don't have to take all of them. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961 +def error_cconv_unsupported : Error< + "%0 calling convention not supported %select{" + // Use CallingConventionIgnoredReason Enum to specif

[PATCH] D64780: Disallow most calling convention attributes on PS4.

rjmccall added a comment. I'm fine with the idea of targets making unsupported CCs hard errors. Comment at: test/Sema/no_callconv.cpp:44 +void __attribute__((sysv_abi)) funcI() {} +void __attribute__((cdecl)) funcC() {} Please include a newline at the end of th

[PATCH] D64780: Disallow most calling convention attributes on PS4.

probinson added reviewers: rnk, rjmccall. probinson added a comment. This has my blessing as PS4 code owner, but I'd like other eyes on it with respect to how we've gone about it. + rnk, rjmccall as the most likely suspects. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We wish to disable most calling convention attributes for PS4, allowing just cdecl (and the equivalent sysv_abi on PS4), which are default. Repository: rC Clang https://reviews.llvm