This revision was automatically updated to reflect the committed changes.
Closed by commit rL366467: [clangd] BackgroundIndex stores shards to the
closest project (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kadircet updated this revision to Diff 210621.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64745/new/
https://reviews.llvm.org/D64745
Files:
clang-tools-ex
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:149
+ std::unique_ptr create(PathRef CDBDirectory) {
+assert(!CDBDirectory.empty() &&
+ "Tried to create storage for empty directory!");
sammccall
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG apart from the second global CDB
Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:128
+ : IndexStorageMapMu(llvm::make_unique()),
+
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Changes persistance logic to store shards at the directory of closest
CDB. Previously we were storing all shards t
